Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

Fixed performance regression of CSV reading #657

Merged
merged 1 commit into from
Dec 4, 2021
Merged

Conversation

jorgecarleitao
Copy link
Owner

This was a performance regression introduced to downstream dependencies caused by poor inlining by Rust after the introduction of the async csv reading.

@jorgecarleitao jorgecarleitao added the bug Something isn't working label Dec 3, 2021
@jorgecarleitao jorgecarleitao changed the title Fixed performance regression of CSV reading. Fixed performance regression of CSV reading Dec 3, 2021
@codecov
Copy link

codecov bot commented Dec 3, 2021

Codecov Report

Merging #657 (54e49dc) into main (4320687) will increase coverage by 0.03%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #657      +/-   ##
==========================================
+ Coverage   69.52%   69.56%   +0.03%     
==========================================
  Files         299      299              
  Lines       16739    16735       -4     
==========================================
+ Hits        11638    11641       +3     
+ Misses       5101     5094       -7     
Impacted Files Coverage Δ
src/io/csv/read/deserialize.rs 100.00% <ø> (ø)
src/io/csv/read_async/deserialize.rs 100.00% <ø> (ø)
src/io/csv/read_utils.rs 63.15% <66.66%> (+2.90%) ⬆️
src/io/parquet/read/nested_utils.rs 78.43% <0.00%> (+0.98%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4320687...54e49dc. Read the comment docs.

@jorgecarleitao jorgecarleitao merged commit cb5e644 into main Dec 4, 2021
@jorgecarleitao jorgecarleitao deleted the csv_faster branch December 4, 2021 09:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant