Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

Added support to read dictionary-encoded required parquet pages #683

Merged
merged 1 commit into from
Dec 14, 2021
Merged

Added support to read dictionary-encoded required parquet pages #683

merged 1 commit into from
Dec 14, 2021

Conversation

mdrach
Copy link
Contributor

@mdrach mdrach commented Dec 14, 2021

Addresses #668 .

@codecov
Copy link

codecov bot commented Dec 14, 2021

Codecov Report

Merging #683 (f02bd15) into main (280ed1d) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #683      +/-   ##
==========================================
+ Coverage   69.75%   69.77%   +0.01%     
==========================================
  Files         303      303              
  Lines       16820    16830      +10     
==========================================
+ Hits        11733    11743      +10     
  Misses       5087     5087
Impacted Files Coverage Δ
src/io/parquet/read/fixed_size_binary.rs 64.76% <100.00%> (+3.70%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 280ed1d...f02bd15. Read the comment docs.

@jorgecarleitao jorgecarleitao added the feature A new feature label Dec 14, 2021
@jorgecarleitao jorgecarleitao merged commit fdb8c68 into jorgecarleitao:main Dec 14, 2021
@jorgecarleitao jorgecarleitao changed the title Support parquet read from dictionary-encoded nonoptional pages Added support to read from dictionary-encoded nonoptional parquet pages Dec 14, 2021
@jorgecarleitao jorgecarleitao changed the title Added support to read from dictionary-encoded nonoptional parquet pages Added support to read from dictionary-encoded required parquet pages Dec 14, 2021
@jorgecarleitao jorgecarleitao changed the title Added support to read from dictionary-encoded required parquet pages Added support to read dictionary-encoded required parquet pages Dec 14, 2021
@jorgecarleitao
Copy link
Owner

Looks great, thanks!

@jorgecarleitao jorgecarleitao mentioned this pull request Dec 31, 2021
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
feature A new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mdrach @jorgecarleitao