Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

Added support for compare dictionary-encoded with scalar #686

Merged
merged 1 commit into from
Jan 19, 2022

Conversation

jorgecarleitao
Copy link
Owner

@jorgecarleitao jorgecarleitao commented Dec 16, 2021

E.g.

eq_scalar(&DictionaryArray, &Utf8Scalar<i32>) -> BooleanArray

@jorgecarleitao jorgecarleitao added the feature A new feature label Dec 16, 2021
@jorgecarleitao jorgecarleitao marked this pull request as draft December 16, 2021 05:39
@jorgecarleitao jorgecarleitao marked this pull request as ready for review January 19, 2022 16:51
@jorgecarleitao jorgecarleitao force-pushed the cmp_scalar_dict branch 2 times, most recently from 98ff7f1 to bc068da Compare January 19, 2022 17:16
@codecov
Copy link

codecov bot commented Jan 19, 2022

Codecov Report

Merging #686 (692d65f) into main (84a4911) will increase coverage by 0.03%.
The diff coverage is 54.28%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #686      +/-   ##
==========================================
+ Coverage   70.99%   71.02%   +0.03%     
==========================================
  Files         316      316              
  Lines       16733    16831      +98     
==========================================
+ Hits        11879    11954      +75     
- Misses       4854     4877      +23     
Impacted Files Coverage Δ
src/compute/take/mod.rs 65.85% <ø> (ø)
src/compute/comparison/mod.rs 49.20% <48.38%> (+9.67%) ⬆️
src/types/index.rs 95.23% <100.00%> (+10.38%) ⬆️
src/io/parquet/write/dictionary.rs 54.54% <0.00%> (-1.25%) ⬇️
src/io/ipc/write/schema.rs 97.82% <0.00%> (+0.72%) ⬆️
src/compute/arithmetics/time.rs 26.60% <0.00%> (+0.91%) ⬆️
src/array/mod.rs 71.05% <0.00%> (+1.75%) ⬆️
src/io/parquet/read/mod.rs 46.27% <0.00%> (+6.96%) ⬆️
src/array/dictionary/mod.rs 70.76% <0.00%> (+7.69%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 84a4911...692d65f. Read the comment docs.

@jorgecarleitao jorgecarleitao merged commit 9f25174 into main Jan 19, 2022
@jorgecarleitao jorgecarleitao deleted the cmp_scalar_dict branch January 19, 2022 18:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature A new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant