Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

Moved is_ordered from Field to DataType::Dictionary #711

Merged
merged 1 commit into from
Dec 26, 2021
Merged

Conversation

jorgecarleitao
Copy link
Owner

This allows users of DictionaryArray to check the boolean in its data_type, to specialize sorting of the values by taking the boolean into account.

@codecov
Copy link

codecov bot commented Dec 25, 2021

Codecov Report

Merging #711 (8d4f9b8) into main (87a08f4) will increase coverage by 0.06%.
The diff coverage is 70.14%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #711      +/-   ##
==========================================
+ Coverage   70.17%   70.23%   +0.06%     
==========================================
  Files         309      309              
  Lines       16802    16820      +18     
==========================================
+ Hits        11790    11814      +24     
+ Misses       5012     5006       -6     
Impacted Files Coverage Δ
src/compute/arithmetics/mod.rs 69.81% <0.00%> (ø)
src/compute/cast/dictionary_to.rs 24.39% <0.00%> (ø)
src/compute/take/mod.rs 65.85% <ø> (ø)
src/io/avro/read/nested.rs 44.44% <ø> (ø)
src/io/json_integration/mod.rs 0.00% <0.00%> (ø)
src/io/parquet/read/primitive/mod.rs 41.02% <0.00%> (ø)
src/compute/cast/mod.rs 93.91% <40.00%> (ø)
src/compute/sort/mod.rs 26.66% <50.00%> (ø)
src/io/json_integration/schema.rs 45.79% <63.63%> (-0.03%) ⬇️
src/array/dictionary/mod.rs 63.07% <66.66%> (-0.99%) ⬇️
... and 21 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 87a08f4...8d4f9b8. Read the comment docs.

@jorgecarleitao jorgecarleitao merged commit f33a41f into main Dec 26, 2021
@jorgecarleitao jorgecarleitao deleted the is_ordered branch December 26, 2021 18:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant