Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

add ordering #726

Closed
wants to merge 4 commits into from
Closed

add ordering #726

wants to merge 4 commits into from

Conversation

Igosuki
Copy link
Contributor

@Igosuki Igosuki commented Jan 3, 2022

Hi guys, I'm currently trying out arrow2 with the latest master from datafusion. The following updates were necessary because TypeSignature is ordered.

P.S. : The other commits are just me removing code only needed to add Decimal support.

@codecov
Copy link

codecov bot commented Jan 3, 2022

Codecov Report

Merging #726 (b67e9b4) into main (b617331) will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #726      +/-   ##
==========================================
+ Coverage   70.22%   70.26%   +0.03%     
==========================================
  Files         312      312              
  Lines       16995    17016      +21     
==========================================
+ Hits        11935    11956      +21     
  Misses       5060     5060              
Impacted Files Coverage Δ
src/datatypes/field.rs 27.45% <ø> (ø)
src/datatypes/mod.rs 81.39% <ø> (ø)
src/datatypes/physical_type.rs 100.00% <ø> (ø)
src/compute/arithmetics/time.rs 26.60% <0.00%> (+0.91%) ⬆️
src/bitmap/utils/slice_iterator.rs 92.53% <0.00%> (+1.49%) ⬆️
src/compute/boolean_kleene.rs 76.19% <0.00%> (+4.76%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b617331...b67e9b4. Read the comment docs.

@jorgecarleitao
Copy link
Owner

Thanks for this PR. Could you check #379?

@Igosuki
Copy link
Contributor Author

Igosuki commented Jan 10, 2022

Ok, so the requirement for PartialOrd is lifted so we can close this !

@Igosuki Igosuki closed this Jan 10, 2022
@jorgecarleitao
Copy link
Owner

Thanks @Igosuki , and also for all your work in the datafusion migration 🙇

@Igosuki
Copy link
Contributor Author

Igosuki commented Jan 11, 2022 via email

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants