Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

Simplified avro reading and added more tests #737

Merged
merged 1 commit into from
Jan 31, 2022
Merged

Conversation

jorgecarleitao
Copy link
Owner

No description provided.

@jorgecarleitao jorgecarleitao added the testing PRs that only increase coverage label Jan 6, 2022
@jorgecarleitao jorgecarleitao changed the title Simplified avro and added tests Simplified avro reading and added tests Jan 6, 2022
@codecov
Copy link

codecov bot commented Jan 6, 2022

Codecov Report

Merging #737 (5b9a17f) into main (601fa08) will increase coverage by 0.34%.
The diff coverage is 88.88%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #737      +/-   ##
==========================================
+ Coverage   71.08%   71.43%   +0.34%     
==========================================
  Files         319      319              
  Lines       16672    16676       +4     
==========================================
+ Hits        11851    11912      +61     
+ Misses       4821     4764      -57     
Impacted Files Coverage Δ
src/io/avro/read/schema.rs 58.22% <ø> (+3.38%) ⬆️
src/io/avro/write/serialize.rs 85.91% <88.88%> (+35.10%) ⬆️
src/io/parquet/read/nested_utils.rs 77.45% <0.00%> (-0.99%) ⬇️
src/compute/arithmetics/time.rs 26.60% <0.00%> (+0.91%) ⬆️
src/array/binary/mutable.rs 78.57% <0.00%> (+1.29%) ⬆️
src/io/avro/write/schema.rs 66.66% <0.00%> (+3.03%) ⬆️
src/io/avro/read/deserialize.rs 74.79% <0.00%> (+3.25%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 601fa08...5b9a17f. Read the comment docs.

@jorgecarleitao jorgecarleitao changed the title Simplified avro reading and added tests Simplified avro reading and added more tests Jan 6, 2022
@jorgecarleitao
Copy link
Owner Author

This is blocked by UB triggered on a dependency. See WanzenBug/rle-decode-helper#8 for details

@jorgecarleitao
Copy link
Owner Author

Got unblocked, re-triggering CI

@jorgecarleitao
Copy link
Owner Author

Thanks a lot @WanzenBug for the release that made the MIRI pass here :)

@jorgecarleitao jorgecarleitao merged commit 086c54d into main Jan 31, 2022
@jorgecarleitao jorgecarleitao deleted the improved_avro branch January 31, 2022 18:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
testing PRs that only increase coverage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant