Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

Added support to deserialize JSON (!= NDJSON) #758

Merged
merged 1 commit into from
Jan 12, 2022
Merged

Added support to deserialize JSON (!= NDJSON) #758

merged 1 commit into from
Jan 12, 2022

Conversation

jorgecarleitao
Copy link
Owner

@jorgecarleitao jorgecarleitao commented Jan 11, 2022

So far the crate only supported reading NDJSON (by splitting the file with \n and reading it in chunks). This PR adds support to deserialize JSON.

It also adds an example demonstrating how to use it.

It also enables reading arrays with structs (missed by #750)

Closes #712

@jorgecarleitao jorgecarleitao added the feature A new feature label Jan 11, 2022
@codecov
Copy link

codecov bot commented Jan 11, 2022

Codecov Report

Merging #758 (e2720e4) into main (79bb05c) will decrease coverage by 0.01%.
The diff coverage is 86.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #758      +/-   ##
==========================================
- Coverage   70.98%   70.97%   -0.02%     
==========================================
  Files         313      313              
  Lines       16919    16936      +17     
==========================================
+ Hits        12010    12020      +10     
- Misses       4909     4916       +7     
Impacted Files Coverage Δ
src/io/json/read/mod.rs 66.66% <ø> (ø)
src/io/json/read/infer_schema.rs 86.48% <84.61%> (+0.90%) ⬆️
src/io/json/read/deserialize.rs 68.83% <100.00%> (+0.41%) ⬆️
src/array/fixed_size_binary/iterator.rs 75.00% <0.00%> (-16.67%) ⬇️
src/compute/arithmetics/time.rs 25.68% <0.00%> (-0.92%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 79bb05c...e2720e4. Read the comment docs.

@jorgecarleitao jorgecarleitao changed the title Added support to read JSON (!= NDJSON) Added support to deserialize JSON (!= NDJSON) Jan 11, 2022
@jorgecarleitao jorgecarleitao merged commit dc8f230 into main Jan 12, 2022
@jorgecarleitao jorgecarleitao deleted the json branch January 12, 2022 20:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature A new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support to read JSON
1 participant