Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

Added support to write LargeUtf8 and LargeBinary to Avro #828

Merged

Conversation

illumination-k
Copy link
Contributor

@illumination-k illumination-k commented Feb 10, 2022

  • convert LargeUtf8 and LargeBinary schema to avro::String and avro::Bytes when converting from datatype to avro schema.
  • adding a test for LargeUtf8 and LargeBinary io

@codecov
Copy link

codecov bot commented Feb 10, 2022

Codecov Report

Merging #828 (de46e98) into main (2c4dbb2) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #828      +/-   ##
==========================================
+ Coverage   71.55%   71.57%   +0.02%     
==========================================
  Files         326      326              
  Lines       17643    17645       +2     
==========================================
+ Hits        12624    12630       +6     
+ Misses       5019     5015       -4     
Impacted Files Coverage Δ
src/io/avro/write/schema.rs 68.57% <100.00%> (+1.90%) ⬆️
src/io/avro/write/serialize.rs 84.41% <0.00%> (+2.59%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c4dbb2...de46e98. Read the comment docs.

@jorgecarleitao jorgecarleitao merged commit 48761ac into jorgecarleitao:main Feb 10, 2022
@jorgecarleitao
Copy link
Owner

Woops, forgot to convert the schema :/ Many thanks, @illumination-k !

@jorgecarleitao jorgecarleitao added the enhancement An improvement to an existing feature label Feb 10, 2022
@jorgecarleitao jorgecarleitao changed the title Supporting LargeUtf8 and LargeBinary for avro schema Added support to write LargeUtf8 and LargeBinary to Avro Feb 10, 2022
@illumination-k illumination-k deleted the feature/write_avro_schema branch February 10, 2022 17:35
@jorgecarleitao jorgecarleitao added feature A new feature and removed enhancement An improvement to an existing feature labels Mar 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature A new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants