This repository has been archived by the owner on Feb 18, 2024. It is now read-only.
Fixed wrong null_count when slicing a sliced Bitmap #848
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #848 +/- ##
=======================================
Coverage 71.49% 71.49%
=======================================
Files 335 335
Lines 17910 17910
=======================================
Hits 12805 12805
Misses 5105 5105
Continue to review full report at Codecov.
|
When pre-calculating the null_count on a Bitmap we need to start from the correct place in the underlying byte-array (i.e. take into account that we may already be looking at a slice). Currently, when we slice of a small part (so that we enter the first branch of the null_count choice), the null_count assumes that the current offset is 0, but it should not. This adds a test for this situation and fixes the issue.
|
Looks good @satlank, thanks a lot! |
|
this is a serious semantic bug. Thank you so much @satlank for finding and fixing! 💯 |
jorgecarleitao
changed the title
|
My pleasure @jorgecarleitao, did cause a bit of head-scratching but luckily easy fix ;-) Thanks for this crate, it is proving quite useful! |
sydduckworth
pushed a commit
to mindx/arrow2
that referenced
this pull request
Mar 2, 2022
When pre-calculating the null_count on a Bitmap we need to start from the correct place in the underlying byte-array (i.e. take into account that we may already be looking at a slice). Currently, when we slice of a small part (so that we enter the first branch of the null_count choice), the null_count assumes that the current offset is 0, but it should not. This adds a test for this situation and fixes the issue.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When pre-calculating the null_count on a Bitmap we need to start from
the correct place in the underlying byte-array (i.e. take into account
that we may already be looking at a slice). Currently, when we slice of
a small part (so that we enter the first branch of the null_count
choice), the null_count assumes that the current offset is 0, but it
should not.
This adds a test for this situation and fixes the issue.