This repository has been archived by the owner on Feb 18, 2024. It is now read-only.
Add lifetime parameterization to async IPC reader #851
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ahhhh, you won the war I started (and lost a battle with) the compiler. Thank you! 🙇 |
Codecov Report
@@ Coverage Diff @@
## main #851 +/- ##
=======================================
Coverage 71.49% 71.49%
=======================================
Files 335 335
Lines 17910 17910
=======================================
+ Hits 12804 12805 +1
+ Misses 5106 5105 -1
Continue to review full report at Codecov.
|
sydduckworth
pushed a commit
to mindx/arrow2
that referenced
this pull request
Mar 2, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #850.
Pretty small ergonomic change.