This repository has been archived by the owner on Feb 18, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 223
Improved performance and stability of writing to CSV #866
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #866 +/- ##
==========================================
- Coverage 71.56% 71.52% -0.04%
==========================================
Files 335 335
Lines 17952 17989 +37
==========================================
+ Hits 12847 12867 +20
- Misses 5105 5122 +17
Continue to review full report at Codecov.
|
|
ritchie46
force-pushed
the
csv_write
branch
2 times, most recently
from
February 25, 2022 11:42
5cb5da2
to
2805aea
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great PR!
Indeed this will be more performant. I left one comment.
ritchie46
commented
Feb 25, 2022
It should be good to go. |
jorgecarleitao
changed the title
change csv-writer
Improved performance and stability of writing to CSV
Feb 26, 2022
Indeed. Thanks a lot, @ritchie46 ! |
sydduckworth
pushed a commit
to mindx/arrow2
that referenced
this pull request
Mar 2, 2022
sydduckworth
pushed a commit
to mindx/arrow2
that referenced
this pull request
Mar 2, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses #865. It is a breaking change, but it gives us more control and very likely improves performance because we only use
csv-core
forutf8
fields.Because we have a lot less variants than the original csv crate has to deal with. E.g.