Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

expose ListValuesIter #874

Merged
merged 1 commit into from
Mar 3, 2022
Merged

Conversation

ritchie46
Copy link
Collaborator

I want to implement a trait for an arrow defined iterator. This makes that possible.

@codecov
Copy link

codecov bot commented Mar 2, 2022

Codecov Report

Merging #874 (b5caedb) into main (5d0db54) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #874      +/-   ##
==========================================
+ Coverage   71.48%   71.50%   +0.01%     
==========================================
  Files         335      335              
  Lines       17969    18147     +178     
==========================================
+ Hits        12846    12976     +130     
- Misses       5123     5171      +48     
Impacted Files Coverage Δ
src/array/mod.rs 62.76% <ø> (ø)
src/array/list/iterator.rs 62.50% <100.00%> (ø)
src/array/list/mod.rs 70.53% <0.00%> (-10.95%) ⬇️
src/array/specification.rs 84.44% <0.00%> (-7.45%) ⬇️
src/array/binary/mod.rs 86.13% <0.00%> (-1.22%) ⬇️
src/compute/arithmetics/time.rs 25.68% <0.00%> (-0.92%) ⬇️
src/array/primitive/mod.rs 80.85% <0.00%> (+0.61%) ⬆️
src/array/fixed_size_list/mod.rs 72.50% <0.00%> (+0.83%) ⬆️
src/array/utf8/mod.rs 66.66% <0.00%> (+1.17%) ⬆️
src/bitmap/utils/slice_iterator.rs 87.93% <0.00%> (+1.72%) ⬆️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d0db54...b5caedb. Read the comment docs.

@@ -13,7 +13,7 @@ pub struct ListValuesIter<'a, A: IterableListArray> {

impl<'a, A: IterableListArray> ListValuesIter<'a, A> {
#[inline]
pub fn new(array: &'a A) -> Self {
pub(crate) fn new(array: &'a A) -> Self {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doesn't this need to be public for you to use it?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We get it by calling values_iter on a list array. Don't think we need a new publicly? Don't have much opinion about it though.

@jorgecarleitao jorgecarleitao merged commit 66616dd into jorgecarleitao:main Mar 3, 2022
@jorgecarleitao jorgecarleitao added the enhancement An improvement to an existing feature label Mar 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement An improvement to an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants