Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

Made IPC IO use try_new #879

Merged
merged 1 commit into from
Mar 5, 2022
Merged

Made IPC IO use try_new #879

merged 1 commit into from
Mar 5, 2022

Conversation

jorgecarleitao
Copy link
Owner

This makes deviations to the arrow spec coming from IPC to error instead of to panic, making us a bit more resilient on that.

@jorgecarleitao jorgecarleitao added the enhancement An improvement to an existing feature label Mar 3, 2022
@codecov
Copy link

codecov bot commented Mar 3, 2022

Codecov Report

Merging #879 (9a78ba4) into main (a87c758) will decrease coverage by 0.05%.
The diff coverage is 70.27%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #879      +/-   ##
==========================================
- Coverage   71.67%   71.62%   -0.06%     
==========================================
  Files         335      335              
  Lines       18205    18188      -17     
==========================================
- Hits        13049    13027      -22     
- Misses       5156     5161       +5     
Impacted Files Coverage Δ
src/array/boolean/ffi.rs 0.00% <0.00%> (ø)
src/array/boolean/mutable.rs 83.61% <ø> (ø)
src/array/fixed_size_binary/ffi.rs 0.00% <0.00%> (ø)
src/array/fixed_size_binary/mutable.rs 68.88% <0.00%> (ø)
src/array/fixed_size_list/mod.rs 70.00% <0.00%> (-2.50%) ⬇️
src/array/fixed_size_list/mutable.rs 47.05% <0.00%> (ø)
src/array/growable/fixed_binary.rs 68.75% <ø> (ø)
src/array/growable/fixed_size_list.rs 47.61% <0.00%> (ø)
src/array/growable/list.rs 96.66% <ø> (ø)
src/array/growable/structure.rs 88.23% <ø> (ø)
... and 79 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a87c758...9a78ba4. Read the comment docs.

@jorgecarleitao jorgecarleitao merged commit 1b7e8ee into main Mar 5, 2022
@jorgecarleitao jorgecarleitao deleted the new branch March 5, 2022 14:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement An improvement to an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant