This repository has been archived by the owner on Feb 18, 2024. It is now read-only.
Fixed unsoundness of #derive(Clone) for FFI structs
#882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #882 +/- ##
=======================================
Coverage 71.67% 71.68%
=======================================
Files 335 335
Lines 18205 18205
=======================================
+ Hits 13049 13050 +1
+ Misses 5156 5155 -1
Continue to review full report at Codecov.
|
jorgecarleitao
changed the title
#derive(Clone) for FFI structs
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The implementation is not sound as it allows for double-free if someone clones the struct.
Closes #880