Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

Use more idiomatic versions #898

Merged
merged 1 commit into from
Mar 9, 2022
Merged

Use more idiomatic versions #898

merged 1 commit into from
Mar 9, 2022

Conversation

jorgecarleitao
Copy link
Owner

  • Buffer::from_trusted_len_iter -> .collect::<Vec<_>>().into()
  • Buffer::try_from_trusted_len_iter -> .collect::<Result<Vec<_>>>()?.into()

and un-nested some if-else statements.

@jorgecarleitao jorgecarleitao added the enhancement An improvement to an existing feature label Mar 9, 2022
@codecov
Copy link

codecov bot commented Mar 9, 2022

Codecov Report

Merging #898 (2bf7015) into main (3f0983b) will increase coverage by 0.00%.
The diff coverage is 88.70%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #898   +/-   ##
=======================================
  Coverage   70.28%   70.29%           
=======================================
  Files         344      344           
  Lines       18794    18801    +7     
=======================================
+ Hits        13210    13216    +6     
- Misses       5584     5585    +1     
Impacted Files Coverage Δ
src/buffer/immutable.rs 92.85% <ø> (-3.58%) ⬇️
src/compute/arity.rs 77.77% <76.00%> (+0.44%) ⬆️
src/compute/arithmetics/decimal/add.rs 96.55% <87.50%> (+0.18%) ⬆️
src/compute/arithmetics/decimal/sub.rs 96.49% <87.50%> (+0.19%) ⬆️
src/compute/arithmetics/decimal/div.rs 77.50% <88.23%> (+0.87%) ⬆️
src/compute/arithmetics/decimal/mul.rs 76.54% <88.23%> (+0.90%) ⬆️
src/compute/cast/binary_to.rs 80.55% <100.00%> (+0.55%) ⬆️
src/compute/cast/boolean_to.rs 100.00% <100.00%> (ø)
src/compute/hash.rs 100.00% <100.00%> (ø)
src/compute/length.rs 100.00% <100.00%> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f0983b...2bf7015. Read the comment docs.

@jorgecarleitao jorgecarleitao merged commit 4269aef into main Mar 9, 2022
@jorgecarleitao jorgecarleitao deleted the idiom branch March 9, 2022 07:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement An improvement to an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant