Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

remove csv dependency for csv-write #917

Merged
merged 1 commit into from
Mar 16, 2022

Conversation

ritchie46
Copy link
Collaborator

For feature io_csv_write we only need csv-core. So this PR removes the csv dependency under that feature flag.

@codecov
Copy link

codecov bot commented Mar 15, 2022

Codecov Report

Merging #917 (8395147) into main (52b3cc5) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #917   +/-   ##
=======================================
  Coverage   71.12%   71.12%           
=======================================
  Files         346      346           
  Lines       18890    18890           
=======================================
+ Hits        13435    13436    +1     
+ Misses       5455     5454    -1     
Impacted Files Coverage Δ
src/io/csv/mod.rs 0.00% <ø> (ø)
src/io/csv/write/mod.rs 57.77% <ø> (ø)
src/bitmap/utils/slice_iterator.rs 87.93% <0.00%> (+1.72%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 52b3cc5...8395147. Read the comment docs.

@jorgecarleitao jorgecarleitao merged commit 47edf30 into jorgecarleitao:main Mar 16, 2022
@jorgecarleitao jorgecarleitao added the enhancement An improvement to an existing feature label Mar 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement An improvement to an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants