Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

Fixed wrong clippy warning #938

Merged
merged 1 commit into from
Apr 12, 2022
Merged

Fixed wrong clippy warning #938

merged 1 commit into from
Apr 12, 2022

Conversation

jorgecarleitao
Copy link
Owner

The fixed in clippy missed the 1.60 cut and will be in 1.61, see rust-lang/rust-clippy#8463 . Meanwhile, we ignore it.

@jorgecarleitao jorgecarleitao added the testing PRs that only increase coverage label Apr 12, 2022
@codecov
Copy link

codecov bot commented Apr 12, 2022

Codecov Report

Merging #938 (7d1cf92) into main (36b0824) will increase coverage by 0.34%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #938      +/-   ##
==========================================
+ Coverage   71.10%   71.45%   +0.34%     
==========================================
  Files         346      346              
  Lines       18951    19206     +255     
==========================================
+ Hits        13476    13724     +248     
- Misses       5475     5482       +7     
Impacted Files Coverage Δ
src/io/ipc/write/serialize.rs 65.18% <ø> (ø)
src/compute/filter.rs 60.13% <0.00%> (-1.70%) ⬇️
src/bitmap/mutable.rs 93.38% <0.00%> (+2.74%) ⬆️
src/io/csv/write/serialize.rs 72.04% <0.00%> (+12.44%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 36b0824...7d1cf92. Read the comment docs.

@jorgecarleitao jorgecarleitao merged commit 0d93c58 into main Apr 12, 2022
@jorgecarleitao jorgecarleitao deleted the fix_clippy branch April 12, 2022 05:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
testing PRs that only increase coverage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant