This repository has been archived by the owner on Feb 18, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the reading of IPC dictionaries to when they are needed.
If a file has dictionaries, currently we read them to memory when reading the files' metadata. This causes metadata reading quite expensive if dictionaries exist.
This PR makes reading of dictionaries happen when the first IPC record batch is requested (via
.next
orpoll
forsync
andasync
respectively), which allows users that just want to read the metadata to not have to read dictionaries.The other advantage of this approach is that it allows projection push down to be applied to dictionaries, where we skip dictionaries that are not needed (follow-up PR).