Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

Prevented SO in large parquet files #973

Merged
merged 1 commit into from
Apr 30, 2022

Conversation

ritchie46
Copy link
Collaborator

Partial fix for pola-rs/polars#3120

This stops infinite recursion with arrays with very large values.

@codecov
Copy link

codecov bot commented Apr 30, 2022

Codecov Report

Merging #973 (55df561) into main (3810da5) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #973      +/-   ##
==========================================
- Coverage   71.51%   71.51%   -0.01%     
==========================================
  Files         355      355              
  Lines       19631    19631              
==========================================
- Hits        14040    14039       -1     
- Misses       5591     5592       +1     
Impacted Files Coverage Δ
src/io/parquet/write/mod.rs 58.51% <100.00%> (ø)
src/compute/arithmetics/time.rs 25.68% <0.00%> (-0.92%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3810da5...55df561. Read the comment docs.

@jorgecarleitao jorgecarleitao merged commit b668a22 into jorgecarleitao:main Apr 30, 2022
@jorgecarleitao jorgecarleitao changed the title prevent SO in large parquet files Prevented SO in large parquet files Apr 30, 2022
@jorgecarleitao jorgecarleitao added the bug Something isn't working label Apr 30, 2022
@ritchie46 ritchie46 deleted the fix_so branch May 1, 2022 07:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants