Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

Fixed decoding Binary Plain pages with dictionary pages #982

Merged
merged 1 commit into from
May 6, 2022

Conversation

aptr322
Copy link
Contributor

@aptr322 aptr322 commented May 6, 2022

This patch fixes decoding nested binary columns

@codecov
Copy link

codecov bot commented May 6, 2022

Codecov Report

Merging #982 (1352de5) into main (d035964) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main     #982      +/-   ##
==========================================
- Coverage   71.40%   71.40%   -0.01%     
==========================================
  Files         357      357              
  Lines       19728    19728              
==========================================
- Hits        14087    14086       -1     
- Misses       5641     5642       +1     
Impacted Files Coverage Δ
src/io/parquet/read/deserialize/binary/nested.rs 61.25% <0.00%> (ø)
src/compute/arithmetics/time.rs 25.68% <0.00%> (-0.92%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d035964...1352de5. Read the comment docs.

@jorgecarleitao jorgecarleitao changed the title fix decoding Binary Plain pages Fixed decoding Binary Plain pages with dictionary pages May 6, 2022
@jorgecarleitao jorgecarleitao added the bug Something isn't working label May 6, 2022
@jorgecarleitao jorgecarleitao merged commit 7d0908f into jorgecarleitao:main May 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants