Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved performance of codec initialization #63

Merged
merged 1 commit into from
Oct 18, 2021
Merged

Conversation

jorgecarleitao
Copy link
Owner

@jorgecarleitao jorgecarleitao commented Oct 17, 2021

Removes an un-needed allocation when initializing a codec.

backward incompatible changes

To migrate:

Code such as

let mut codec = create_codec(compression)?;
codec.decompress(...)?
// or
codec.compress(...)?

use

compression::decompress(compression, ...)
compression::compress(compression, ...)

which does not require a boxed trait object.

@codecov-commenter
Copy link

codecov-commenter commented Oct 17, 2021

Codecov Report

Merging #63 (5c4e3b1) into main (7fbf8e4) will decrease coverage by 0.14%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #63      +/-   ##
==========================================
- Coverage   66.52%   66.38%   -0.15%     
==========================================
  Files          65       65              
  Lines        3594     3567      -27     
==========================================
- Hits         2391     2368      -23     
+ Misses       1203     1199       -4     
Impacted Files Coverage Δ
src/write/compression.rs 0.00% <0.00%> (ø)
src/read/compression.rs 56.33% <55.55%> (-0.81%) ⬇️
src/compression.rs 88.57% <78.37%> (+1.07%) ⬆️
src/page/page_dict/mod.rs 52.63% <100.00%> (-2.37%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7fbf8e4...5c4e3b1. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants