Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allows for depots with non-default stream depths #13

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Allows for depots with non-default stream depths #13

wants to merge 2 commits into from

Conversation

thejustinwalsh
Copy link
Contributor

Fix for issue #12.

  • It may not be idiomatic rust.
  • The logic could likely be simplified, as the stream name without the depot prefixed is not emitted from the function.
  • Tests ensure it works like it used to while supporting bespoke stream depth setups.

@thejustinwalsh
Copy link
Contributor Author

Added logic to migrate any existing projects that are using a non-defaul stream depth.

@parnic-sks
Copy link

🚀 👍

@thejustinwalsh thejustinwalsh marked this pull request as draft July 25, 2024 17:46
@thejustinwalsh
Copy link
Contributor Author

While this appears to make the DB entries look correct, it did not work once I did a test deployment.
I might need @jorgenpt's help on this one.

@thejustinwalsh thejustinwalsh mentioned this pull request Jul 25, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thejustinwalsh @parnic-sks