Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error message was confusing with silent enabled. #173

Merged
merged 1 commit into from
Dec 21, 2020
Merged

Error message was confusing with silent enabled. #173

merged 1 commit into from
Dec 21, 2020

Conversation

PW999
Copy link
Contributor

@PW999 PW999 commented Dec 21, 2020

If the silent option was enabled, no violations were printed.
The error message then referred to non-existing "above violations".

@PW999
Copy link
Contributor Author

PW999 commented Dec 21, 2020

Should have installed the gitlint commit hook prior to pushing this commit 😄

If the silent option was enabled, no violations were printed.
The error message then referred to non-existing "above violations".
@jorisroovers jorisroovers merged commit e06dfe0 into jorisroovers:main Dec 21, 2020
jorisroovers added a commit that referenced this pull request Apr 16, 2021
Bugfixes:
  - Git commit message body with only new lines is not longer considered empty
    by `body-is-missing` (#176)
  - Added compatibility with `git commit -s` for
    `contrib-requires-signed-off-by` rule (#178)
- Minor tweak to gitlint commit-hook output (#173)
- All dependencies have been upgraded to the latest available versions
- Minor doc fixes

Full Release details in CHANGELOG.md.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants