Handle empty commit list in --commits (#22) #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a "index out of range" exception when the specified git range for --commits is empty. Fixes jorisroovers#22.
|
The OSX test doesn't seem to be starting. |
|
Thanks :)
Yeah, there is an issue with the OSX tests on Travis that I don't think has anything to do with gitlint. I've reached out to Travis but haven't heard back yet. With this merge, I'm going to release v0.8.1. I would've liked to have more tests and fixes for some of the other issues (#23 and #24), but I likely won't have time for those in the remainder of the week. Since I want to unblock you on zulip/zulip#1131, I'll just note that the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a "index out of range" exception when the specified git range for --commits is empty.
Fixes #22.