No longer require a TTY connected to STDIN to read from local git repo #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this commit, gitlint defaulted to reading the latest commit message from the local git repository when it found a TTY connected to STDIN, falling back to reading from STDIN in all other cases. With this commit, gitlint will do the opposite which is more sane: it will only read from STDIN in case there's input on STDIN, falling back to reading from the local git repo in all other cases. This is especially useful for environments where there is no TTY attached to STDIN like in many CI environments. This fixes #40, #42.
jorisroovers
added a commit
that referenced
this pull request
Dec 3, 2017
Before this commit, gitlint defaulted to reading the latest commit message from the local git repository when it found a TTY connected to STDIN, falling back to reading from STDIN in all other cases. With this commit, gitlint will do the opposite which is more sane: it will only read from STDIN in case there's input on STDIN, falling back to reading from the local git repo in all other cases. This is especially useful for environments where there is no TTY attached to STDIN like in many CI environments. This fixes #40, #42.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this commit, gitlint defaulted to reading the latest commit message
from the local git repository when it found a TTY connected to STDIN,
falling back to reading from STDIN in all other cases.
With this commit, gitlint will do the opposite which is more sane: it will
only read from STDIN in case there's input on STDIN, falling back to reading
from the local git repo in all other cases.
This is especially useful for environments where there is no TTY attached to
STDIN like in many CI environments.
This fixes #40, #42.