Make test_target less strict with git
#79
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rico-chet
force-pushed
the
fix-target-test-too-strict
branch
from
e9d2c75 to
87136e1
Compare
…vers#76) - Various text fixes all over - Enable lint tests for Python 3.6 - Fix some pylint warnings - Ignore pylint errors for bad options - Use unittest2 only for Python 2 - Test Python 3.7 in Travis - Integration Tests: Introduce assertEqualStdout - Activate all integration tests in Travis - Update dependencies in requirements.txt
rico-chet
force-pushed
the
fix-target-test-too-strict
branch
from
87136e1 to
98fb940
Compare
An expectation of the `test_target` is that `git` prints a specific error message when run outside a workdir. This message was changed in one of the last `git` releases, so the test fails. Make the `test_target` less strict regarding the message content, just looking for the 'not a git repository' ought to be enough.
rico-chet
force-pushed
the
fix-target-test-too-strict
branch
from
98fb940 to
29f427a
Compare
|
This PR adjusted the test while the issue was really with the underlying gitlint code. Currently working on v0.11.0 which includes this fix, will be out today. Closing this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An expectation of the
test_targetis thatgitprints a specificerror message when run outside a workdir. This message was changed in
one of the last
gitreleases, so the test fails.Make the
test_targetless strict regarding the message content, justlooking for the 'not a git repository' ought to be enough.
Fixes #78 for me