Fixed SQS Queue policy and SNS subscription dependency on Main Queue

jormaechea · Sep 26, 2024 · 674cf56 · 674cf56
1 parent 002cc07
commit 674cf56
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 4 deletions.
diff --git a/lib/sqs-helper/index.js b/lib/sqs-helper/index.js
@@ -306,7 +306,8 @@ module.exports = class SQSHelper {
 								}
 							]
 						}
-					}
+					},
+					DependsOn: [this.names.mainQueue]
 				}
 			}]
 		];
@@ -327,7 +328,8 @@ module.exports = class SQSHelper {
 						Endpoint: this.arns.mainQueue,
 						RawMessageDelivery: true,
 						TopicArn: generateSnsArns(this.sourceSnsTopicName).topic
-					}
+					},
+					DependsOn: [this.names.mainQueue]
 				}
 			}]
 		];

diff --git a/tests/unit/hook-builder/sqs.js b/tests/unit/hook-builder/sqs.js
@@ -195,7 +195,8 @@ describe('Hook Builder Helpers', () => {
 							}
 						]
 					}
-				}
+				},
+				DependsOn: ['TestQueue']
 			}
 		}];
 
@@ -208,7 +209,8 @@ describe('Hook Builder Helpers', () => {
 					Endpoint: 'arn:aws:sqs:${aws:region}:${aws:accountId}:${self:custom.serviceName}TestQueue',
 					RawMessageDelivery: true,
 					TopicArn: 'arn:aws:sns:${aws:region}:${aws:accountId}:TestTopic'
-				}
+				},
+				DependsOn: ['TestQueue']
 			}
 		}];