feat: Add option to eigs() to turn off eigenvector computation #3057
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josdejong
reviewed
Oct 5, 2023
There was a problem hiding this comment.
Thanks Glen, this looks good. I made one small remark, can you have a look in to that?
It looks like the PR has merge conflicts, not sure what's going on. #3037 is merged now, feel free to create a new PR if that's easier than fixing these conflicts.
Note that I changed the PR to merge into the v12 branch.
For large matrices, the eigenvector computation can be noticeably expensive and so it's worthwhile to have a way to turn it off if the eigenvectors will not be used. Resolves josdejong#2180.
And also a fix for a small bug that the new test uncovered.
gwhitney
force-pushed
the
only_eigenvalues_stacked
branch
from
ab4e364
to
6d9f759
Compare
|
I guess I need to add a matrix with options object test? Will try that. |
|
OK, I guess codecov is pointing out there is now useless code in complexEigs.js. Will take that out. |
josdejong
reviewed
Oct 11, 2023
|
Thanks for the latest updates, I'll now merge this PR in the |
|
Published in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For large matrices, the eigenvector computation can be noticeably expensive
and so it's worthwhile to have a way to turn it off if the eigenvectors
will not be used.
Resolves #2180.
Note that this PR is stacked on #3037, so it should only be merged into develop after that one has been.