Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/2919 type exports (export the static functions manually) #3078

Closed
wants to merge 3 commits into from

Conversation

josdejong
Copy link
Owner

Fix #2919 using the approach of Maxim worked out in #2932.

Changes:

  • Renamed MathJsStatic into MathJsInstance
  • The dependencies are no longer exported in MathJsInstance (they are not exported there in reality)
  • Export all functions and constants of MathJsInstance as static constants.
  • Document how to properly define types in types/EXPLANATION.md

To do:

  • Bring the types up to date with all changes done in the v12 branch
  • Test thoroughly

@josdejong josdejong changed the title Fix/2919 type exports (dumb way) Fix/2919 type exports (export the static functions manually) Oct 12, 2023
@josdejong josdejong closed this Oct 12, 2023
@josdejong josdejong deleted the fix/2919_type_exports_dump_way branch October 12, 2023 10:23
@josdejong josdejong restored the fix/2919_type_exports_dump_way branch October 12, 2023 10:25
@josdejong
Copy link
Owner Author

Oops I hadn't realized that renaming the branch would close this PR.

Created a new PR: #3079

@josdejong josdejong deleted the fix/2919_type_exports_dump_way branch October 12, 2023 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant