Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: onRenderContextMenu context selection #376

Merged
merged 5 commits into from
Jan 10, 2024
Merged

feat: onRenderContextMenu context selection #376

merged 5 commits into from
Jan 10, 2024

Conversation

1pone
Copy link
Contributor

@1pone 1pone commented Dec 21, 2023 •
edited
Loading

feat:
Using the context values selection, different actions can be taken depending on the path of selection.

fix:
package.json @lezer/highlight

josdejong
josdejong requested changes Dec 22, 2023
View reviewed changes
Copy link
Owner

@josdejong josdejong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, passing the selection along with onRenderContextMenu makes sense!

I made a couple of inline comments, can you have a look at those?

README.md Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
pnpm-lock.yaml Outdated Show resolved Hide resolved
src/routes/development/+page.svelte Outdated Show resolved Hide resolved
@1pone
Copy link
Contributor Author

1pone commented Dec 25, 2023

done

@josdejong
Copy link
Owner

Thanks for the updates! Merging now.

@josdejong josdejong merged commit 2068823 into josdejong:main Jan 10, 2024
4 checks passed
@josdejong
Copy link
Owner

Published now in v0.21.2. Thanks again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josdejong josdejong josdejong approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@1pone @josdejong @Xremn