-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: hidden value plugins #397
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Jesse!
I made two small inline comments, can you have a look at those?
<div | ||
role="button" | ||
tabindex="-1" | ||
class="jse-value jse-readonly-password" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you rename the class to jse-hidden-value
?
@@ -13,7 +14,15 @@ export * from './types.js' | |||
// value plugins | |||
export { renderValue } from './plugins/value/renderValue.js' | |||
export { renderJSONSchemaEnum } from './plugins/value/renderJSONSchemaEnum.js' | |||
export { BooleanToggle, ColorPicker, EditableValue, EnumValue, ReadonlyValue, TimestampTag } | |||
export { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you also mention this new component in the README?
https://github.com/josdejong/svelte-jsoneditor/blob/main/README.md?plain=1#L286
I had a look into the long term solution that is discussed in #375 to make it possible to create components in vanilla JS, and it turns out using Svelte actions works like a charm, see #398. If we have that solution working, this |
Wonderful! I'll try to implement it by myself in vanilla JS as soon as it's officially released. At that point, I'll close this pr if it works. |
I've finished and merged #398 (not yet published) |
Export
HiddenValue
value plugins, to fix the inability to customize value components for version vanilla