Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: hidden value plugins #397

Closed
wants to merge 1 commit into from
Closed

Conversation

1pone
Copy link
Contributor

@1pone 1pone commented Jan 23, 2024

Export HiddenValue value plugins, to fix the inability to customize value components for version vanilla

Copy link
Owner

@josdejong josdejong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Jesse!

I made two small inline comments, can you have a look at those?

<div
role="button"
tabindex="-1"
class="jse-value jse-readonly-password"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you rename the class to jse-hidden-value?

@@ -13,7 +14,15 @@ export * from './types.js'
// value plugins
export { renderValue } from './plugins/value/renderValue.js'
export { renderJSONSchemaEnum } from './plugins/value/renderJSONSchemaEnum.js'
export { BooleanToggle, ColorPicker, EditableValue, EnumValue, ReadonlyValue, TimestampTag }
export {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@josdejong
Copy link
Owner

I had a look into the long term solution that is discussed in #375 to make it possible to create components in vanilla JS, and it turns out using Svelte actions works like a charm, see #398.

If we have that solution working, this HiddenValue component is probably not needed: you can implement it yourself then (and refine the experience to make it a true password component). What do you think?

@1pone
Copy link
Contributor Author

1pone commented Jan 26, 2024

Wonderful! I'll try to implement it by myself in vanilla JS as soon as it's officially released. At that point, I'll close this pr if it works.

@josdejong
Copy link
Owner

I've finished and merged #398 (not yet published)

@1pone 1pone closed this Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants