Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Pass validation severity into UI #416

Merged
merged 3 commits into from
Mar 27, 2024

Conversation

anlinguist
Copy link
Contributor

@anlinguist anlinguist commented Mar 14, 2024

This PR addresses the following discussion and issues:

Allows the validation error severity to be warning (yellow), error (red), or info(blue).

If the validation error table is collapsed, it uses the first validation error to determine the color to show.
If the validation error table is opened, each validation error will be the assigned color from the validator.
Also updated the hover color for each validation error.

@josdejong
Copy link
Owner

Thanks Andrew! I'll review your PR next week.

Copy link
Owner

@josdejong josdejong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for working out this solution Andrew, this looks good. I made a couple of inline comments. Can you have a look at those?

@josdejong
Copy link
Owner

Thanks for the updates, this looks really good, both the code and the UI!

@josdejong
Copy link
Owner

I see there is a linting issue, I'll fix that right after merging.

@josdejong josdejong merged commit 6cd6af9 into josdejong:main Mar 27, 2024
3 of 4 checks passed
@josdejong
Copy link
Owner

josdejong commented Mar 27, 2024

After merging I thought it would be neat to rename the helper function getValidationClass to getMaxSeverity, I've changed that in 2c88d93 and 8a6a1de. I hope you don't mind.

@josdejong
Copy link
Owner

Published now in v0.23.1, thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants