Merge branch 'develop'

HISTORY.md

@@ -1,6 +1,11 @@
 # History
 
 
+## 2024-06-05, version 4.2.1
+
+- Fix a bug in the new `override` option of method `addConversion`.
+
+
 ## 2024-06-05, version 4.2.0
 
 - Extend methods `addConversion` and `addConversions` with a new option 

package.json

@@ -1,6 +1,6 @@
 {
   "name": "typed-function",
-  "version": "4.2.0",
+  "version": "4.2.1",
   "description": "Type checking for JavaScript functions",
   "author": "Jos de Jong <wjosdejong@gmail.com> (https://github.com/josdejong)",
   "contributors": [

src/typed-function.mjs

@@ -1878,7 +1878,7 @@ function create () {
 
     if (existing) {
       if (options && options.override) {
-        to.conversionsTo.splice(existing.index, 1)
+        typed.removeConversion({ from: existing.from, to: conversion.to, convert: existing.convert })
       } else {
         throw new Error(
           'There is already a conversion from "' + conversion.from + '" to "' +

test/conversion.test.js

@@ -101,6 +101,11 @@ describe('conversion', function () {
   it('should override a conversion using addConversions', function () {
     const typed2 = typed.create()
 
+    // we add an unrelated conversion to ensure we cannot misuse the internal .index 
+    // (which is more like an auto incrementing id)
+    const conversionUnrelated = { from: 'string', to: 'boolean', convert: () => 'c' }
+    typed2.addConversion(conversionUnrelated)
+
     const conversionA = { from: 'number', to: 'string', convert: () => 'a' }
     const conversionB = { from: 'number', to: 'string', convert: () => 'b' }