Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Css Background Support. Updated Support for IE. Added CSS filters incase canvas has issues. #4

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

mintystark
Copy link

No description provided.

…ork.

Added CSS Background Image Support, Added CSS incase Canvas doesn't work.
Fixed issues with IE.  The original code was not working with IE 9 and 10.  
It has been tested with IE 9,10,11  FF 31, Chrome 36, Safari 7
@josefrichter
Copy link
Owner

hey, thanks! line 21-24 of the original file - why would you remove the ms filters and put there canvas? the problem was that anything below IE9 didn't support canvas, but it did support those filters.. maybe even IE9+ still supports those filters which is actually a better solution than this canvas "hack"..

@mintystark
Copy link
Author

Actually, IE9 did not work for me until I removed those lines. Same for IE10. Also I don't care about anything under IE9.
So if you still want to offer IE8 and below you would want to include those lines again, but add a version check as well for IE8 IE7, Etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants