Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix exhaustiveness checking for union types #505

Merged
merged 3 commits into from
Jan 26, 2023
Merged

Fix exhaustiveness checking for union types #505

merged 3 commits into from
Jan 26, 2023

Commits on Jan 23, 2023

  1. Fix exhaustiveness checking for union types 

    When one pattern matched more than one "part of the union",
their GLB was computed as the type that the pattern covers.
But I think it should be their LUB instead.

Fixes issue josefs#477, one known problem, and removes the need for
one particular workaround in typechecker.erl.
    @xxdavid
    xxdavid committed Jan 23, 2023
    Configuration menu
    Copy the full SHA
    001fe6d View commit details
    Browse the repository at this point in the history

Commits on Jan 26, 2023

  1. Extract some tests to test/known_problems/should_pass/intersection_sh… 

    …ould_pass.erl
    @erszcz
    erszcz committed Jan 26, 2023
    Configuration menu
    Copy the full SHA
    27b6f43 View commit details
    Browse the repository at this point in the history

  2. Add test/should_fail/intersection_fail.erl

    @erszcz
    erszcz committed Jan 26, 2023
    Configuration menu
    Copy the full SHA
    d8c97b8 View commit details
    Browse the repository at this point in the history