Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tiny mods to confirm functionality #31

Merged
merged 5 commits into from
Aug 30, 2016
Merged

Tiny mods to confirm functionality #31

merged 5 commits into from
Aug 30, 2016

Conversation

jadb
Copy link
Contributor

@jadb jadb commented Aug 30, 2016

Refs #26 and #27

josegonzalez
josegonzalez reviewed Aug 30, 2016
View reviewed changes
src/josegonzalez/Dotenv/Loader.php
@@ -2,8 +2,6 @@

namespace josegonzalez\Dotenv;

use InvalidArgumentException;
use josegonzalez\Dotenv\Expect;
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer explicit loading of classes over implicit. Please revert this.

@coveralls
Copy link

coveralls commented Aug 30, 2016 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling e8c5a53 on jadb:tiny-mods-to-confirm-func into eb9eb3b on josegonzalez:master.

@coveralls
Copy link

coveralls commented Aug 30, 2016 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling e8c5a53 on jadb:tiny-mods-to-confirm-func into eb9eb3b on josegonzalez:master.

@josegonzalez josegonzalez merged commit 879a161 into josegonzalez:master Aug 30, 2016
@jadb jadb deleted the tiny-mods-to-confirm-func branch August 30, 2016 02:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jadb @coveralls @josegonzalez