Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: offer docs how to run in docker #211

Closed
EugenMayer opened this issue May 25, 2023 · 4 comments · Fixed by #222
Closed

Feature: offer docs how to run in docker #211

EugenMayer opened this issue May 25, 2023 · 4 comments · Fixed by #222

Comments

@EugenMayer
Copy link

Thank you for the great tool! We dockerized the pyhon lib to reduce the host system requirements and also isolate the run to a non privileged user to ensure everything is encapsulated if something goes wrong. See https://github.com/KontextWork/docker-github-backup

Should be as easy as

docker run --rm ghcr.io/kontextwork/github-backup --help
# or
docker run --rm ghcr.io/kontextwork/github-backup josegonzalez --repositories -t $TOKEN

See https://github.com/KontextWork/docker-github-backup for more

If there is and interest i would make an PR to update the docs

@ZhymabekRoman
Copy link
Contributor

ZhymabekRoman commented Jun 24, 2023

Thanks for work! I want to mention that there is an alternative implementation: https://github.com/umputun/github-backup-docker

@josegonzalez
Copy link
Owner

Pull requests welcome.

@EugenMayer
Copy link
Author

EugenMayer commented Jun 24, 2023

@ZhymabekRoman sorry - i assume i might be biased so i try to be extra objective:
The linked docker image does run under root. Considering we are dealing with a sensible operation like backup, on a backup server, running it as root in a container can have serious issues if anything goes rough. This is why i used a non root setup.

To be fair though, the image you linked is daemonized and runs a cron job itself - this is what mine does not offer (by desing). The image i desinged is specifically as a "cli replacement without deps leaking". I do like to combine my tools with restik, thus retention handling and all those things are not needed in the tool that "pulls the snapshot". That was the design idea.

So it might be worth mentioning both - the cli "one shot" image i created and the "daemon" variant from umputun.

@josegonzalez happy to do so, just since we have 2 candidates here, you have pick on for the PR i guess. As we see, it is needed, or we end up having more of the duplicate "dockerized" repos :) Let me know

@josegonzalez
Copy link
Owner

I'd rather the Dockerfile exist in this repository, and doesn't run as a daemon/cron. Folks can use their scheduler to do such a thing if they want vs running a persistent cron daemon in the image.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants