Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: create Dockerfile #222

Merged
merged 1 commit into from
Dec 9, 2023
Merged

Conversation

pl4nty
Copy link
Contributor

@pl4nty pl4nty commented Oct 28, 2023

The resulting image can be used like docker run ghcr.io/pl4nty/github-backup pl4nty --token $TOKEN. With some docs and a first-party image via GitHub Actions, this could close #211.

It might also be usable for local development, but I'm not sure of the difference between requirements.txt and release-requirements.txt. I used the latter.

Build results: https://github.com/pl4nty/containers/actions/runs/6675073097/job/18142653711

Copy link
Owner

@josegonzalez josegonzalez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this just install the latest version of the package instead of trying to do a development release?

@pl4nty
Copy link
Contributor Author

pl4nty commented Oct 29, 2023

@josegonzalez I used the PyPI package previously, but it would make CI/CD difficult. eg Docker build would have to run after PyPI release, and pre-release Docker images might not be possible without manually updating the Dockerfile.

@josegonzalez josegonzalez merged commit 4e7d6f7 into josegonzalez:master Dec 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: offer docs how to run in docker
2 participants