Detect empty HTTPS contexts. #344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some users are relying solely on the certifi package to provide their CA certs, as requests does this by default. This patch detects this situation and emits a clear warning as well as importing certifi to work around the situation.. Fixes josegonzalez#162 .
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some users are relying solely on the
certifipackage to provide their CA certs, asrequestsdoes this by default.This patch detects this situation and emits a clear warning as well as importing
certifito work around the situation..Fixes #162 .
Addendum:
If this project is still providing compatibility with Python 2.7, I have not implemented that here at this time.
Addendum 2:
It is also possible the user's OS certificates are not up-to-date. This solution does not detect that scenario. It could be detected by catching the exception mentioned in the linked issue.
Addendum 3:
Regarding requests, this topic has been considered in 2016 at psf/requests#2966 .
It looks like currently the correct solution is to use https://pypi.org/project/truststore/ . I am out of time at the moment to submit new code here.