Add Fundle install support #30
Conversation
IMO your PR looks more like a feature rather than a fix since as I understood you want to add
Yeah, you could send a new PR introducing that change if you want. |
| @@ -8,11 +8,19 @@ set -q fish_functions; or set -g fish_functions "$fish_config/functions" | |||
| set -q fish_completions; or set -g fish_completions "$fish_config/completions" | |||
| set -q GITNOW_CONFIG_FILE; or set -g GITNOW_CONFIG_FILE ~/.gitnow | |||
|
|
|||
| set -g gitnow_version 2.6.0 | |||
| set -g gitnow_version 2.7.0 | |||
There was a problem hiding this comment.
Why that change? Are you using the latest master? Can you sync your PR branch please?
https://github.com/joseluisq/gitnow/blob/master/conf.d/gitnow_config.fish#L11
There was a problem hiding this comment.
Oh my bad. I simply pulled from master when forking, then made the fundle-compat branch after editting the file.
There was a problem hiding this comment.
Wait, on master it's 2.6 too.
I honestly don't know what happened there, that is quite odd. I'll revert it.
There was a problem hiding this comment.
Basically you need to sync your fork first.
|
And probably you also want to update the |
SirWrexes
changed the title
|
I'm working on adding the other things like editing the README etc. |
Yes, Just let it as it is as current Gitnow |
this commit also speeds up gitnow commands like: tag, logs, move, gitflow, github and bitbucket
--quiet is deprecated (fish-shell/fish-shell@bfb5b28)
--quiet is deprecated (fish-shell/fish-shell@bfb5b28)
Config file parsing (.gitnow) was written completely and as result it boosts performance startup of GitNow up to 62% faster avg. Stats: Old parser (v2.6.0): Executed in 223,04 millis fish external usr time 209,69 millis 636,00 micros 209,06 millis sys time 31,97 millis 175,00 micros 31,80 millis New parser: Executed in 84,62 millis fish external usr time 63,87 millis 0,00 micros 63,87 millis sys time 24,04 millis 921,00 micros 23,12 millis
it limits max number of commits to 80 by default
|
Alright. I have added the installation instructions to I also took time to add a disclaimer about 2.7.0 not supporting Fundle yet in the "Latest stable" installation instructions. Since Fundle's README isn't very clear about how to get a particular version of a plugin and it's not extremely user friendly, I thought it was better having the installation method + a note rather than nothing. It will save you some time later too I guess. Synchronising my fork in between two commits made squashing take longer than expected but everything seems to be in order and working fine. I'll push the squashed commits. |
|
Wow seeing the whole history come up in there because of the sync issue sure is a scary thing. |
Understand, but unfortunately the history is a bit messy I recommend do a new PR with just your commit changes. |
|
Feel free to sync your fork or re-fork Gitnow again and open a new PR again. |
|
I totally understand. |
Hey there,
I'm not a fan of installing plugins straight into where I put my own configs.
Nonetheless, I've been using Fisher for a while until, recently, jorgebucaran/fisher#651 broke everything.
I kept getting annoying warnings telling me to delete my plugin files in order to update them blablabla... but I digress.
I switched to Fundle, which works more elegantly IMO by placing plugins in a dedicated directory tree then sourcing everything.
Luckily, there are several ways of checking if a user has Fundle, and one of them is querying
functionstoo see if__fundle_plugins_direxists, which will then serve to tell us where Gitnow has been installed.I quickly wrote a fix with this method, while retaining the pretty handy variables you created.
Note that
fish_configcould also be set using the value from the standard__fish_config_dirvariable.Have a good day ! 👋