refactor: Set fish_config with $__fish_config_dir

[SirWrexes]

Hello,
Is this to your liking ?
Have a good day. 👋

[joseluisq]

Everything is fine. The only minor change that you could do taking advantage of your PR is this one on line 15:

-set -q GITNOW_CONFIG_FILE; or set -g GITNOW_CONFIG_FILE ~/.gitnow
+set -q GITNOW_CONFIG_FILE; or set -g GITNOW_CONFIG_FILE "$HOME/.gitnow"

[SirWrexes]

Well I know it's a very rare occurrence but I did happen to have some programs not recognise '~' once or twice, whereas expanding an environment variable should always work and I don't really see how $HOME could be missing from the environment when spawning a shell.
I guess it's mostly a preference thing in the end though.
Shall I do the change ?

[joseluisq]

Well I know it's a very rare occurrence but I did happen to have some programs not recognise '~' once or twice, whereas expanding an environment variable should always work and I don't really see how $HOME could be missing from the environment when spawning a shell.

$HOME env is part of POSIX specification which means it must be present on system.

I guess it's mostly a preference thing in the end though.

Yes, just concordance with your PR. But yeah in practice both are essentially the same.

Shall I do the change ?

It is just a suggestion for "convention only" since your are introducing a $HOME too.
BTW this is the only place where ~ is used for paths.

[SirWrexes]

Alrighty then !

[joseluisq]

Thanks!

[joseluisq]

Published on release 2.8.0