NewRelic scaler crashes on logging (kedacore#3946)

Signed-off-by: Laszlo Kishalmi <laszlo.kishalmi@partech.com> Signed-off-by: Laszlo Kishalmi <laszlo.kishalmi@partech.com>
josephangbc · Dec 6, 2022 · 13c273b · 13c273b
1 parent 5901daa
commit 13c273b
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -77,6 +77,7 @@ To learn more about active deprecations, we recommend checking [GitHub Discussio
 - **General:** Provide patch for CVE-2022-3172 vulnerability ([#3690](https://github.com/kedacore/keda/issues/3690))
 - **General:** Respect optional parameter inside envs for ScaledJobs ([#3568](https://github.com/kedacore/keda/issues/3568))
 - **Azure Blob Scaler** Store forgotten logger ([#3811](https://github.com/kedacore/keda/issues/3811))
+- **New Relic Scaler** Store forgotten logger ([#3945](https://github.com/kedacore/keda/issues/3945))
 - **Prometheus Scaler:** Treat Inf the same as Null result ([#3644](https://github.com/kedacore/keda/issues/3644))
 - **NATS Jetstream:** Correctly count messages that should be redelivered (waiting for ack) towards keda value ([#3787](https://github.com/kedacore/keda/issues/3787))
 

diff --git a/pkg/scalers/newrelic_scaler.go b/pkg/scalers/newrelic_scaler.go
@@ -71,7 +71,8 @@ func NewNewRelicScaler(config *ScalerConfig) (Scaler, error) {
 	return &newrelicScaler{
 		metricType: metricType,
 		metadata:   meta,
-		nrClient:   nrClient}, nil
+		nrClient:   nrClient,
+		logger:     logger}, nil
 }
 
 func parseNewRelicMetadata(config *ScalerConfig, logger logr.Logger) (*newrelicMetadata, error) {