Merge pull request #3 from josephshambrook/chore/upgrades

Upgrade Cypress and other packages
josephshambrook · Apr 12, 2021 · 6dca2fe · 6dca2fe
2 parents 3eac1bd + beab0c9
commit 6dca2fe
Show file tree

Hide file tree

Showing 5 changed files with 34,470 additions and 8,333 deletions.
diff --git a/README.md b/README.md
@@ -27,4 +27,4 @@ These functionalities make it possible to test the following in Cypress:
 - In a separate Terminal instance, run `npm run cy:open` to open Cypress' UI.
   - Alternatively, `npm run cy:run` will run all Cypress tests in one go, with recordings and screenshots
 
-> Note: I recommend using iTerm to run separate Terminal instances in split-screen.
+> Note: I recommend using [iTerm](https://iterm2.com/) or [Hyper](https://hyper.is/) to run separate Terminal instances in split-screen.
diff --git a/cypress/integration/04-hacker-news.spec.js b/cypress/integration/04-hacker-news.spec.js
@@ -1,10 +1,4 @@
 describe('Hacker News', () => {
-  context('API requests slow', () => {
-    before(() => {});
-
-    it('should display the loading title, then replace it with the card', () => {});
-  });
-
   context('API calls return errors', () => {
     it('should display nothing when the topstories URL fails', () => {});
 
@@ -18,4 +12,10 @@ describe('Hacker News', () => {
 
     it('displays a link to the post, which opens in a new tab', () => {});
   });
+
+  context('API requests slow', () => {
+    before(() => {});
+
+    it('should display the loading title, then replace it with the card', () => {});
+  });
 });
diff --git a/cypress/integration/cheating/04-hacker-news.spec.js b/cypress/integration/cheating/04-hacker-news.spec.js
@@ -1,57 +1,37 @@
 import { TOP_STORIES } from '../../../src/urls';
 
 describe('Hacker News', () => {
-  context('API requests slow', () => {
-    before(() => {
-      cy.server({
-        delay: 1000,
+  context('API calls return errors', () => {
+    it('should display nothing when the topstories URL fails', () => {
+      cy.intercept(TOP_STORIES, {
+        statusCode: 404,
+        body: [],
       });
-      cy.route(TOP_STORIES, 'fixture:topstories.json').as('topstories');
-      cy.route('**/item/22008566*', 'fixture:item.json').as('item');
       cy.visit('/');
-    });
-
-    it('should display the loading title, then replace it with the card', () => {
-      cy.getTestId('hn-loading').should('be.visible');
-      cy.getTestId('hn-card').should('not.be.visible');
 
-      cy.wait('@item');
-      cy.getTestId('hn-loading').should('not.be.visible');
-      cy.getTestId('hn-card').should('be.visible');
+      cy.getTestId('hn-loading').should('not.exist');
+      cy.getTestId('hn-card').should('not.exist');
     });
-  });
 
-  context('API calls return errors', () => {
     it('should display nothing when the topstories URL fails', () => {
-      cy.server();
-      cy.route({
-        url: TOP_STORIES,
-        status: 404,
-        response: [],
+      cy.intercept('**/item/**', {
+        statusCode: 404,
+        body: {},
       });
-      cy.reload();
-      cy.getTestId('hn-loading').should('not.be.visible');
-      cy.getTestId('hn-card').should('not.be.visible');
-    });
+      cy.visit('/');
 
-    it('should display nothing when the topstories URL fails', () => {
-      cy.server();
-      cy.route({
-        url: '**/item/**',
-        status: 404,
-        response: {},
-      });
-      cy.reload();
-      cy.getTestId('hn-loading').should('not.be.visible');
-      cy.getTestId('hn-card').should('not.be.visible');
+      cy.getTestId('hn-loading').should('not.exist');
+      cy.getTestId('hn-card').should('not.exist');
     });
   });
 
   context('Card content when API call is successful', () => {
     beforeEach(() => {
-      cy.server();
-      cy.route(TOP_STORIES, 'fixture:topstories.json').as('topstories');
-      cy.route('**/item/22008566*', 'fixture:item.json').as('item');
+      cy.intercept(TOP_STORIES, { fixture: 'topstories.json' }).as(
+        'topstories'
+      );
+      cy.intercept('**/item/22008566*', { fixture: 'item.json' }).as('item');
+
       cy.visit('/');
       cy.wait('@topstories');
     });
@@ -72,4 +52,26 @@ describe('Hacker News', () => {
       );
     });
   });
+
+  context('API requests slow', () => {
+    before(() => {
+      cy.intercept(TOP_STORIES, { fixture: 'topstories.json', delay: 2000 }).as(
+        'topstories'
+      );
+      cy.intercept('**/item/22008566*', {
+        fixture: 'item.json',
+        delay: 2000,
+      }).as('item');
+      cy.visit('/');
+    });
+
+    it('should display the loading title, then replace it with the card', () => {
+      cy.getTestId('hn-loading').should('be.visible');
+      cy.getTestId('hn-card').should('not.exist');
+
+      cy.wait('@item');
+      cy.getTestId('hn-loading').should('not.exist');
+      cy.getTestId('hn-card').should('be.visible');
+    });
+  });
 });