Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reward attribution when breaking blocks without permission #65

Closed
wtfrankjs opened this issue Jan 7, 2025 · 10 comments
Closed

Reward attribution when breaking blocks without permission #65

wtfrankjs opened this issue Jan 7, 2025 · 10 comments

Comments

@wtfrankjs
Copy link

I am experiencing an issue with the RealMines plugin on my Minecraft server. When players mine blocks from a specific mine, they receive multiple rewards instead of just one. The issue persists regardless of the reward configuration.

Here are the steps I have already taken to try and resolve the issue:

Verified the mines.yml configuration file to ensure rewards are not duplicated or overlapping.
Checked the chance values for each reward to ensure they do not all trigger at once.
Updated RealMines to the latest version available.
Tested the plugin on a separate server with no other plugins to avoid conflicts.
Enabled or checked the exclusive_rewards setting (if available) to ensure only one reward is given per action.

Minecraft server version: (1.21.1)
RealMines plugin version: (1.8.2 in config:8)

@joserodpt
Copy link
Owner

There's no exclusive_rewards setting. Send config file.

@wtfrankjs
Copy link
Author

wtfrankjs commented Jan 7, 2025

After the lowest level values, it gives the values ​​before it, it gives all of them

config:

Mine4.txt
its .yml

@wtfrankjs
Copy link
Author

wtfrankjs commented Jan 7, 2025

every mine is same and the issiue is same purpur 1.21.1
if u want to check: play.viayxempire.com
gamemode: theempire
/warp madenalani

@wtfrankjs
Copy link
Author

I discovered another bug. When I close the event and deactivate block breaking, when they break the block, it does not break, but the reward continues to come.

@wtfrankjs
Copy link
Author

Do you will fix ?

@joserodpt
Copy link
Owner

This will be fixed when I have time

joserodpt added a commit that referenced this issue Jan 17, 2025
@joserodpt
Copy link
Owner

joserodpt commented Jan 17, 2025

Regarding your first issue, it has been solved in the .jar file attached below, please test it and give me some feedback:
RealMines.jar.zip

Regarding your other issue "deactivate block breaking, when they break the block, it does not break, but the reward continues to come." couldn't reproduce this behaviour, so it is working as intended. If it still happens with that build, send more details as to how can I reproduce it.

Thanks for reporting! :)

@wtfrankjs
Copy link
Author

I have 4 mining areas within a protected region using WorldGuard, and each area should be accessible to players with different ranks. However, there's an ongoing issue where players without the proper rank can still receive rewards when breaking blocks in areas they don’t have permission for. For example, when a regular player breaks blocks in the VIP area from the outside, they still get rewards, even though the blocks don’t actually break due to protections.

@joserodpt joserodpt reopened this Jan 18, 2025
@joserodpt
Copy link
Owner

joserodpt commented Jan 18, 2025

That's also a good report. Are you using RealMines as protection? If not, what plugin are you using?

@joserodpt joserodpt changed the title multiple rewards instead of just one Reward attribution when breaking blocks without permission Jan 18, 2025
@neziw
Copy link
Collaborator

neziw commented Feb 2, 2025

going to close this issue due to inactivity

@neziw neziw closed this as completed Feb 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants