Make ::path match directories as well as files #1204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christian-schilling
force-pushed
the
@changes/master/christian.schilling.de@gmail.com/match-dirs-and-files
branch
from
dd54a44
to
3ace6a0
Compare
LMG
approved these changes
May 16, 2023
Previously `::path/` only matched directories while `::path` only matched files. With this change `::path` matches both, while keeping the behaviour of `::path/` as is. This is in line on how things are handled in git's gitignore pattern syntax. Change: match-dirs-and-files
christian-schilling
force-pushed
the
@changes/master/christian.schilling.de@gmail.com/match-dirs-and-files
branch
from
3ace6a0
to
920b1a5
Compare
LMG
deleted the
@changes/master/christian.schilling.de@gmail.com/match-dirs-and-files
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously
::path/only matched directories while::pathonly matched files.With this change
::pathmatches both, while keeping the behaviour of::path/as is.This is in line on how things are handled in git's gitignore pattern syntax.
Change: match-dirs-and-files