This repository has been archived by the owner on Oct 24, 2020. It is now read-only.
MSSQL Support #18
Open
MSSQL Support #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conflicts: metadata.json
Updated Preface with license and upgrade information. Added DB types to iddb.
Updated metadata
…t hybernate dialect in init instead of template
joshbeard
suggested changes
Apr 23, 2019
| @@ -16,7 +16,6 @@ | |||
| password => $crowd::password, | |||
| password_min_age => '0', | |||
| password_max_age => '99999', | |||
| managehome => false, | |||
There was a problem hiding this comment.
Unrelated change. If this needs to be optional, a separate PR or issue can be opened.
|
|
||
| validate_bool($download_driver) | ||
| if $db == 'mysql' { | ||
| validate_re($mysql_driver, '^((https?|ftps?):\/\/)([\da-z\.-]+)\.?([\da-z\.]{2,6})([\/\w \.\:-]*)*\/?\.jar$') | ||
| validate_re($mysql_driver, '^((https?|ftps?|puppet?):\/\/\/?)(([\da-z\.-]+)\.?([\da-z\.]{2,6}):?([\/\w \.-]*)*\/?\.jar$)') | ||
| # validate_re($mysql_driver, '^((https?|ftps?|puppet?):\/\/\/?)([\da-z\.-]+)\.?([\da-z\.]{2,6})([\/\w \.\:-]*)*\/?\.jar$') |
There was a problem hiding this comment.
Please uncomment/remove what isn't used here.
| @@ -83,11 +85,13 @@ | |||
| validate_string($password) | |||
| validate_absolute_path($shell) | |||
|
|
|||
| validate_re($download_url, '^((https?|ftps?):\/\/)([\da-z\.-]+)\.?([\da-z\.]{2,6})([\/\w \.\:-]*)*\/?$') | |||
| validate_re($download_url, '^((https?|ftps?|puppet?):\/\/\/?)(([\da-z\.-]+)\.?([\da-z\.]{2,6})(:?)([\/\w \.-]*)*\/?)??$') | |||
| # validate_re($download_url, '^((https?|ftps?|puppet?):\/\/\/?)(([\da-z\.-]+)\.?([a-z\.]{2,6})([\/\w \.-]*)*\/)??$') | |||
There was a problem hiding this comment.
Please uncomment/remove what isn't used here.
| @@ -46,6 +46,8 @@ | |||
| $iddbname = 'crowdid', | |||
| $iddbport = undef, | |||
| $iddbdriver = undef, | |||
| # $iddbvalidationquery = undef, | |||
| # $iddbhybernatedialect = undef, | |||
There was a problem hiding this comment.
Please uncomment/remove what isn't used here.
| @@ -83,10 +82,15 @@ | |||
| group => $crowd::group, | |||
| } | |||
|
|
|||
| # symlink all logfiles to logging directory | |||
There was a problem hiding this comment.
This doesn't fit in this PR (unrelated). Some work's been done in recent commits to customize the logging directory.
| "issues_url": "https://github.com/joshbeard/puppet-crowd/issues", | ||
| "source": "https://github.com/prikkeldraad/puppet-crowd", | ||
| "project_page": "https://github.com/prikkeldraad/puppet-crowd", | ||
| "issues_url": "https://github.com/prikkeldraad/puppet-crowd/issues", |
| 'ensure' => 'link', | ||
| 'target' => '/var/log/crowd' | ||
| })} | ||
|
|
There was a problem hiding this comment.
Please remove (see other comment about unrelated change)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for MSSQL
Fixed validation queries for PostgrSQL and MSSQL
Linted some failing Travis tests
Fix untitests and regex on URL's and IP
Test on logdir added