Lint/UselessMethodDefinition

Remove method overrides that just call super.

.rubocop_todo.yml

@@ -636,17 +636,6 @@ Lint/SuppressedException:
 Lint/UnusedMethodArgument:
  Enabled: false
 
-# This cop supports unsafe auto-correction (--auto-correct-all).
-Lint/UselessMethodDefinition:
- Exclude:
- - 'lib/puppet/pops/evaluator/closure.rb'
- - 'lib/puppet/pops/types/type_conversion_error.rb'
- - 'lib/puppet/pops/types/type_mismatch_describer.rb'
- - 'lib/puppet/settings/file_or_directory_setting.rb'
- - 'lib/puppet/util/profiler/aggregate.rb'
- - 'lib/puppet/util/rdoc/code_objects.rb'
- - 'lib/puppet/util/rdoc/generators/puppet_generator.rb'
-
 Naming/AccessorMethodName:
  Enabled: false
 

lib/puppet/pops/evaluator/closure.rb

@@ -12,17 +12,9 @@ def initialize(value, file, line)
  end
  end
 
- class Next < Jumper
- def initialize(value, file, line)
- super
- end
- end
+ class Next < Jumper; end
 
- class Return < Jumper
- def initialize(value, file, line)
- super
- end
- end
+ class Return < Jumper; end
 
  class PuppetStopIteration < StopIteration
  attr_reader :file

lib/puppet/pops/types/type_conversion_error.rb

@@ -3,14 +3,5 @@
 module Puppet::Pops::Types
  # Raised when a conversion of a value to another type failed.
  #
- class TypeConversionError < Puppet::Error
-
- # Creates a new instance with a given message
- #
- # @param message [String] The error message describing what failed
- #
- def initialize(message)
- super(message)
- end
- end
+ class TypeConversionError < Puppet::Error; end
 end

lib/puppet/pops/types/type_mismatch_describer.rb

@@ -482,10 +482,6 @@ def range_to_s(range, zero_string)
 
  # @api private
  class CountMismatch < SizeMismatch
- def initialize(path, expected, actual)
- super(path, expected, actual)
- end
-
  def message(variant, position)
  min = expected.from || 0
  max = expected.to || Float::INFINITY

lib/puppet/settings/file_or_directory_setting.rb

@@ -1,10 +1,5 @@
 # frozen_string_literal: true
 class Puppet::Settings::FileOrDirectorySetting < Puppet::Settings::FileSetting
-
- def initialize(args)
- super
- end
-
  def type
  if Puppet::FileSystem.directory?(self.value) || @path_ends_with_slash
  :directory

lib/puppet/util/profiler/aggregate.rb

@@ -16,10 +16,6 @@ def shutdown()
  @logger.call("----------------------------")
  end
 
- def do_start(description, metric_id)
- super(description, metric_id)
- end
-
  def do_finish(context, description, metric_id)
  result = super(context, description, metric_id)
  update_metric(@metrics_hash, metric_id, result[:time])

lib/puppet/util/rdoc/code_objects.rb

@@ -185,10 +185,6 @@ def find_symbol(symbol, method=nil)
  class PuppetNode < PuppetClass
  include AddClassModuleComment
 
- def initialize(name, superclass)
- super(name,superclass)
- end
-
  def is_module?
  false
  end

lib/puppet/util/rdoc/generators/puppet_generator.rb

@@ -650,10 +650,6 @@ def <=>(other)
 
  class HTMLPuppetModule < HtmlClass
 
- def initialize(context, html_file, prefix, options)
- super(context, html_file, prefix, options)
- end
-
  def value_hash
  @values = super