Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to map different types of objects #32

Merged
merged 6 commits into from
Dec 21, 2015
Merged

Add ability to map different types of objects #32

merged 6 commits into from
Dec 21, 2015

Conversation

ealeksandrov
Copy link
Contributor

No description provided.

@jamesbrooks
Copy link
Contributor

From a quick skim, does this allow the use of a protocol rather than subclassing JSONAPIResourceBase? If so a big 👍 :)

@joshdholtz
Copy link
Owner

@jamesbrooks Ahhh, that would be huge
@ealeksandrov Can you confirm? And are there any tests that can be added and updated for this?

@ealeksandrov
Copy link
Contributor Author

@jamesbrooks Not quite that. This is about supporting different kinds of objects for one relationship property.

Added both mapping and serialization support.
Tests also added.

@jkrumow
Copy link
Contributor

jkrumow commented Dec 21, 2015

@joshdholtz Can we please merge this PR?

It adds support for polymorphic types which many API implementations are using.

As discussed here: json-api/json-api#862

@joshdholtz
Copy link
Owner

@ealeksandrov @tarbrain Yes yes, thanks for pinging me 😊 Will merge this and push a pod update this morning 👍

joshdholtz pushed a commit that referenced this pull request Dec 21, 2015
Add ability to map different types of objects
@joshdholtz joshdholtz merged commit 1b00624 into joshdholtz:master Dec 21, 2015
@joshdholtz
Copy link
Owner

@ealeksandrov Thanks for the contribution 🙌 Happy holidays!

@jkrumow
Copy link
Contributor

jkrumow commented Dec 21, 2015

Thanks 👍

@joshdholtz
Copy link
Owner

1.0.3 should be up on CocoaPods now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants