-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for nested test suites #37
Conversation
ekharchenko-avito
commented
Jun 10, 2020
- merged William Petit changes to support suite-in-suite embedding
- added suite Properties fulfillment from attributes (like it already was for testcase)
- added test for that
Added test ingesting phpunit output
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your submission @ekharchenko-avito! This is another interesting edge-case.
PR looks generally fine to me, left a few simple comments.
One thought I had (and I don't really have enough data to have an opinion on this) was that instead of nesting suites the way they are contained in the XML:
suite-a
`- test-a
`- suite-b
`- test-b
`- test-b
Would it make any sense to flatten the structure into something like this:
suite-atest-a
suite-a.suite-b.test-b
suite-a.suite-b.test-b
This transform would be done only to benefit users of the library, but again, I don't have any data to know if that would be the case. Thoughts?
Thanks again, cheers!
Co-authored-by: Josh Komoroske <jdkomo@gmail.com>
That don't make sense for my use case. |
Added test ingesting phpunit output
Apologies for the delay @ekharchenko-avito. Thank you so much for your contribution! 🎉 |