This repository has been archived by the owner on Dec 14, 2018. It is now read-only.
Fix kwargs usage in object calls #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Not all methods in Prospect are tested yet. - BREAKING CHANGE in Prospects.query(): now returns a list of Prospect dicts instead of the raw JSON.
joshgeller
added a commit
that referenced
this pull request
Oct 22, 2014
Fix kwargs usage in object calls
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes prospect.unassign_by_email and prospect.create_by_email, in which the format() call was inserting None into the paths.
Updating the kwargs with object keys is unnecessary, and in these two instances this behavior led to a bug.